Fully support multi-root workspaces #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
afkvido
approved these changes
May 19, 2022
6 tasks
andschwa
force-pushed
the
andschwa/multi-workspace
branch
from
5aa078b
to
710f6d8
Compare
andschwa
changed the title
andschwa
force-pushed
the
andschwa/multi-workspace
branch
from
710f6d8
to
46e0e77
Compare
andschwa
commented
Dec 1, 2022
| @@ -24,6 +24,9 @@ export function getPipePath(pipeName: string) { | |||
| // Check that the file or directory exists in an asynchronous manner that relies | |||
| // solely on the VS Code API, not Node's fs library, ignoring symlinks. | |||
| async function checkIfFileOrDirectoryExists(targetPath: string | vscode.Uri, type: vscode.FileType): Promise<boolean> { | |||
| if (targetPath === "") { | |||
There was a problem hiding this comment.
@SeeminglyScience since the settings overhaul PR, the default cwd was "" which conspicuously vscode.workspace.fs.stat was totally fine saying it existed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #2153.