Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Editor not visible underneath toolbar, tab bar, breadcrumbs, and status bar #911

Open
austincondiff opened this issue Jan 10, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Jan 10, 2023

Description

Editor should scroll "underneath" the toolbar, tab bar, breadcrumbs, and status bar. It should have a blurred effect under these elements. It seems like the editor is cut off.

To Reproduce

Open long file and scroll down. Notice it does not influence the background color of the mentioned elements.

Expected behavior

Blurred content in the editor should appear underneath these elements.

@austincondiff austincondiff added the bug Something isn't working label Jan 10, 2023
@Wouter01
Copy link
Collaborator

I've had a look at it and it seems like there's something broken inside AppKit / SwiftUI which prevents it from working as it should. I've now just removed the background of the toolbar, and drawn my own, which works fine. Does that work for you?

@austincondiff
Copy link
Collaborator Author

austincondiff commented Jan 11, 2023

That should be fine if you are sure it is broken. Will we need to do the same for the breadcrumbs, tabs, and statusbar then? That seems like a lot of custom work. Maybe that is what is necessary though.

@Wouter01
Copy link
Collaborator

That should be fine if you are sure it is broken. Will we need to do the same for the breadcrumbs, tabs, and statusbar then? That seems like a lot of custom work. Maybe that is what is necessary though.

There might be a way to solve it with pure AppKit, but I'm not experienced enough in it to try that. The main problem seems to lie in the safeAreaInset, which you should be able to control the background from, but it doesn't seem to work. There's also a bug in the toolbar implementation of SwiftUI, which I filed feedback for. However, that hasn't really anything to do with the issue here, as we aren't using SwiftUI toolbars.
Anyway, I'll still need to check in the main app itself if I can find a better way to fix it. If not, this solution seems to be working pretty good and will also apply the same blur everywhere. There's also ne extra work to add things like breadcrumbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 馃弮鈥嶁檪锔� In Progress
Development

No branches or pull requests

2 participants