Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader Board : Shows Top Play Contributor of the month and Top Play Contributors of all time #843

Merged
merged 16 commits into from Jan 10, 2023

Conversation

NagarjunShroff
Copy link
Collaborator

@NagarjunShroff NagarjunShroff commented Dec 24, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Shows Top Play Contributor of the month and Top Play Contributors of all time

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

@NagarjunShroff NagarjunShroff self-assigned this Dec 24, 2022
@vercel
Copy link

vercel bot commented Dec 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play Ready (Inspect) Visit Preview Jan 10, 2023 at 1:17PM (UTC)

2. sorting based on date when monthly contributor play count is same.
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NagarjunShroff Initial review comments.

src/common/playleaderboard/LeaderBoard.jsx Outdated Show resolved Hide resolved
src/common/playleaderboard/LeaderBoard.jsx Outdated Show resolved Hide resolved
src/common/playleaderboard/leaderBoard.css Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented Jan 3, 2023

@NagarjunShroff The build consists a bunch of the linting errors. please fix them.

@atapas
Copy link
Member

atapas commented Jan 5, 2023

Hello @NagarjunShroff got a chance to check the comments? Also please resolve conflicts.

@atapas
Copy link
Member

atapas commented Jan 5, 2023

@NagarjunShroff this build fails due to this error:

image

Nagarjun Shroff added 2 commits Jan 9, 2023
@atapas
Copy link
Member

atapas commented Jan 10, 2023

Hi @NagarjunShroff Here are some tiny responsiveness issues I am observing.

  • The images in table gets cut

image

  • This is on a higher resolution screen. The left and right side is a far apart. It creates an impression lot of real estate waste. Can we provide fix such a way that they auto adjust with the gap between the columns?

image

@atapas
Copy link
Member

atapas commented Jan 10, 2023

@NagarjunShroff

I also wanted to ask:

  • Do you have details to link the numbers to the list of plays for all the creators on this page? Or do you suggest that to take as a separate issue?

@NagarjunShroff
Copy link
Collaborator Author

@NagarjunShroff

I also wanted to ask:

  • Do you have details to link the numbers to the list of plays for all the creators on this page? Or do you suggest that to take as a separate issue?

Lets take that up as separate issue.

@atapas
Copy link
Member

atapas commented Jan 10, 2023

@NagarjunShroff
I also wanted to ask:

  • Do you have details to link the numbers to the list of plays for all the creators on this page? Or do you suggest that to take as a separate issue?

Lets take that up as separate issue.

Please create an issue once we merge this one.

@NagarjunShroff
Copy link
Collaborator Author

Hi @NagarjunShroff Here are some tiny responsiveness issues I am observing.

  • The images in table gets cut

image

  • This is on a higher resolution screen. The left and right side is a far apart. It creates an impression lot of real estate waste. Can we provide fix such a way that they auto adjust with the gap between the columns?

image

@atapas Fixed - please test it.

atapas
atapas approved these changes Jan 10, 2023
@atapas atapas linked an issue Jan 10, 2023 that may be closed by this pull request
@atapas
Copy link
Member

atapas commented Jan 10, 2023

LGTM

@atapas atapas merged commit 8e84d87 into main Jan 10, 2023
2 of 3 checks passed
@atapas atapas deleted the Issue-439-Bring-top-creator-of-the-month-and-leader-board branch Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Bring top creator of the month and leader board
2 participants