Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Bump NumPy to 1.20 #24887

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MNT] Bump NumPy to 1.20 #24887

wants to merge 1 commit into from

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Jan 5, 2023

PR Summary

Related to #24884

(Will add release note.)

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus added Run cibuildwheel Run wheel building tests on a PR Maintenance labels Jan 5, 2023
@tacaswell tacaswell added this to the v3.7.0 milestone Jan 5, 2023
@@ -108,7 +108,7 @@ jobs:
CIBW_MANYLINUX_X86_64_IMAGE: manylinux2010
CIBW_MANYLINUX_I686_IMAGE: manylinux2010
CIBW_BEFORE_BUILD: >-
pip install certifi numpy==1.19.2 &&
pip install certifi numpy==1.20.3 &&
Copy link
Member

@tacaswell tacaswell Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern that this is higher than our minimum we tell the packaging system as I am not 100% sure that if we build a wheel with numpy 1.20.3 it will work with numpy 1.20.0. I suspect it will be OK, but we should be sure before we merge.

Copy link
Contributor Author

@oscargus oscargus Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't really understand why it was 1.19.2 earlier and not, say, 1.19.0. (Anyway, since oldest_supported_numpy will be installed in the isolated build environment, I think that is the one being used, so I'll try removing this completely and see what happens...)

Edit: I skipped this as I realized that it is built with --no-deps. But changed to 1.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Run cibuildwheel Run wheel building tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants