Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #14439

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: d1dd3c14-f8e9-46f4-7fb7-08d8446de174
  • Build: 20230505.2
  • Date Produced: May 5, 2023 3:35:43 PM UTC
  • Commit: 5dff25b814b90abb85c847ed274cf4afb2c1b276
  • Branch: refs/heads/main

…205.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22605.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner December 6, 2022 13:03
T-Gro
T-Gro previously approved these changes Dec 6, 2022
@T-Gro T-Gro enabled auto-merge (squash) December 6, 2022 13:19
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge it until machines are updated to VS 17.4, otherwise signed builds will be failing, and insertions will be blocked.

…206.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22606.1
dotnet-maestro bot and others added 19 commits December 9, 2022 13:03
…208.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22608.2
…209.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22609.3
…212.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22612.4
…213.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22613.4
…215.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22615.3
…216.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22616.1
…220.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22620.3
…221.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22621.1
…223.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22623.1
…226.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22626.1
…228.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22628.1
…230.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.22630.1
…102.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23052.2
…103.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23053.5
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't work...

…104.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23054.2
…105.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23055.2
vzarytovskii and others added 8 commits April 20, 2023 15:02
…420.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23220.2
…421.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23221.8
…422.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23222.1
…424.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23224.1
…424.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23224.3
…424.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23224.5
…426.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23226.4
@NikolaMilosavljevic
Copy link
Member

@T-Gro @vzarytovskii fsharp is still on old 7.0 toolset and old beta Arcade. This is blocking source-build work: #15166

Are there still any blockers to merging this PR?

@vzarytovskii
Copy link
Member

@T-Gro @vzarytovskii fsharp is still on old 7.0 toolset and old beta Arcade. This is blocking source-build work: https://github.com/dotnet/fsharp/issues/15166

Are there still any blockers to merging this PR?

Need to fix couple of baseline tests and it should be good to go (for 17.7, 7.0.400 and 8.0)

@vzarytovskii
Copy link
Member

vzarytovskii commented May 2, 2023

This is good to go as long as this CI and signed are green.

When reviewing, keep in mind, that all changes under eng/common are made by arcade's bot.

@dotnet/fsharp-team-msft

vzarytovskii and others added 9 commits May 2, 2023 15:21
…503.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23253.3
…503.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23253.5
…505.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23255.1
…505.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22554.2 -> To Version 8.0.0-beta.23255.2
@NikolaMilosavljevic
Copy link
Member

@T-Gro @vzarytovskii fsharp is still on old 7.0 toolset and old beta Arcade. This is blocking source-build work: #15166
Are there still any blockers to merging this PR?

Need to fix couple of baseline tests and it should be good to go (for 17.7, 7.0.400 and 8.0)

Thanks. It seems that all checks are green except Unresolved conversations. @vzarytovskii who can help resolve those, so PR can be merged?

@vzarytovskii
Copy link
Member

vzarytovskii commented May 8, 2023

@KevinRansom I'm fine merging it, so we unblock source build.
Please note it should be squashed, since it's an arcade bot pr

@vzarytovskii vzarytovskii enabled auto-merge (squash) May 8, 2023 18:30
@vzarytovskii vzarytovskii merged commit 43e32a2 into release/dev17.7 May 8, 2023
27 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-0078935d-6fd1-4bd5-bda8-ff900ad3bfb2 branch May 8, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants