Use fqcn for all modules

[jpopelka]

Previously this was not possible because the modules moved between Ansible 2.9 (previous Zuul) and 6 (Fedora).
Zuul now runs Ansible 6 as well so let's go.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0d976eec197b4654abdc34cdec70a923

✔️ pre-commit SUCCESS in 1m 37s

[jpopelka]

ehm, not gonna fly because in packit-service-tests-openshift we install another ansible to run the make deploy from this repo. And because it runs in centos7, it's still ansible 2.9.

Related packit/packit-service#1900

[TomasTomecek]

so what do we do here?

[jpopelka]

either install ansible from pip (probably the easiest at the moment) or include the (deployment) playbook (in the p-s playbook) instead of running it via another ansible-playbook

[TomasTomecek]

+1 install ansible from pip, ideally so we use the same version everywhere :)

I don't think anyone wants to debug playbooks that run with various ansible versions :D

[jpopelka]

easier said than done;

$ podman run -ti --rm quay.io/centos/centos:centos7 bash
# yum -y install epel-release
# yum -y install python-pip python3-pip
# pip install ansible
Collecting ansible
  Downloading https://files.pythonhosted.org/packages/8b/02/7304f54ac4cba5d4d32551bce7b0743d9b045298790048e07544424c9abc/ansible-7.2.0.tar.gz (37.0MB)
    100% |################################| 37.0MB 41kB/s 
    Complete output from command python setup.py egg_info:
    /usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'project_urls'
      warnings.warn(msg)
    /usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'python_requires'
      warnings.warn(msg)
    error in ansible setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers

# pip3 install ansible
Collecting ansible
  Downloading https://files.pythonhosted.org/packages/fd/f8/071905c6a67592d0852a9f340f6ab9226861eeeb97fdf4068642b22edcf3/ansible-4.10.0.tar.gz
...
UnicodeEncodeError: 'ascii' codec can't encode character '\xe9' in position 82: ordinal not in range(128)

no idea why pip3 thinks the latest version is 4.10.0.

or include the (deployment) playbook (in the p-s playbook) instead of running it via another ansible-playbook

after some experimentation I realized it can be done only at a top level, not inside a play