Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force Ruby platform. #14556

Merged
merged 1 commit into from Feb 8, 2023
Merged

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I have a ~/.bundle/config containing, among other things:

BUNDLE_FORCE_RUBY_PLATFORM: "true"

Running brew tests previously failed with

Your bundle only supports platforms ["aarch64-linux", "arm-linux", "arm64-darwin", "x86_64-darwin", "x86_64-linux"] but your local platform is ruby. Add the current platform to the lockfile with
`bundle lock --add-platform ruby` and try again.

Even if you add the ruby platform, brew tests fails since nokogiri needs native extensions:

Could not find nokogiri-1.13.10-x86_64-darwin in locally installed gems

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-09 at 03:53:07 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 8, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 8, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 8, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

auto-merge was automatically disabled February 8, 2023 09:04

Head branch was pushed to by a user without write access

Bo98
Bo98 approved these changes Feb 8, 2023
@Bo98 Bo98 merged commit 4b752f4 into Homebrew:master Feb 8, 2023
19 checks passed
@reitermarkus reitermarkus deleted the ruby-platform branch February 8, 2023 14:17
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants