Correctly specify platform and architecture for arm32 images #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
reviewed
Mar 7, 2023
| @@ -22,5 +22,5 @@ | |||
| "EndOfLife": "2023-04-02", | |||
| "DistributionState": "Validated", | |||
| "UseInCi": false, | |||
| "Architecture": "arm64" | |||
| "Architecture": "arm32" | |||
There was a problem hiding this comment.
This is more correctly, the host architecture and we don't have an ARM32 host.
We either need to translate this to ARM64 when choosing a host or add another field.
There was a problem hiding this comment.
I think I made the changes to make this work for CI and image build, test and release.
TravisEz13
reviewed
Mar 7, 2023
| @@ -1,7 +1,7 @@ | |||
| # Copyright (c) Microsoft Corporation. | |||
| # Licensed under the MIT License. | |||
|
|
|||
| FROM --platform=linux/arm/v7 ubuntu:bionic AS installer-env | |||
| FROM --platform=linux/arm32v7 ubuntu:bionic AS installer-env | |||
There was a problem hiding this comment.
I think the original was correct.
TravisEz13
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Summary
This PR fixes arm32 images that have "arm64" specified for their architecture property in meta.json and also specifies the platform for the arm32 images.
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.