Use dart test on non-Flutter projects
#1506
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
changed the title
dart test on non-Flutter projects
domesticmouse
approved these changes
Mar 25, 2023
|
I like this approach as it requires less ongoing maintenance. Assuming we can get it to work |
|
Looks like it's working as expected when reading through the logs. I'll merge this and I can monitor if any issues pop-up overtime, but this should at least put us in a better position for Dart projects! |
domesticmouse
added a commit
to domesticmouse/samples
that referenced
this pull request
Mar 25, 2023
Copied from flutter/codelabs#1506
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A change in
test_apicaused an incompatibility with the pinned version offlutter_test. I guess projects should explicitly depend onflutter_testor if not a Flutter project, usedart test.Read dart-lang/test#1977 for more context.
I'm not sure if checking for
flutter:is the best way to decide which command to use, so let me know if you think there's a better way or if we should just use a list of projects to usedartcommands on :)