Do not strip colors when rendering dropdowns #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
added
enhancement
|
The only problem with this is in some cases the highlight can now block the name / is hard to read e.g. uniques. Not a deal breaker though. |
|
Hmm maybe the dropdown highlight could be changed to light grey like when its clicked then it shouldnt interfere with uniques. Someone setting the exactly color as highlight shouldnt really be a problem i think as thats corner case and user responsibility I would say. |
|
light grey can interfere with some of the other dropdowns though |
deathbeam
force-pushed
the
color-dropdowns
branch
from
35e402b
to
2461923
Compare
|
adjusted the dropdown highlight to match hovered highlight |
The coloring is pretty useful for build guides to distringuish different variations. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
force-pushed
the
color-dropdowns
branch
from
2461923
to
95f6d50
Compare
LocalIdentity
approved these changes
Apr 1, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…#5681) The coloring is pretty useful for build guides to distringuish different variations. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coloring is pretty useful for build guides to distringuish different variations.
Signed-off-by: Tomas Slusny slusnucky@gmail.com
Description of the problem being solved:
Colors from dropdowns are stripped and only shown for current selection.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/nnNpYgb5o2CD
Before screenshot:
After screenshot: