jonahwilliams
Follow
Pinned
1,853 contributions in the last year
Activity overview
Contribution activity
May 2023
Created 24 commits in 2 repositories
Created a pull request in flutter/engine that received 20 comments
[Impeller] Use separate atlases and shaders for color and alpha
Creates a separate atlas context and cache for color and alpha bitmap glyphs. Removes SDF shader and uses separate shader for full color glyphs. Re…
+224
−515
•
20
comments
Opened 33 other pull requests in 2 repositories
flutter/engine
7
open
21
merged
4
closed
- [Impeller] Support tessellation of non-convex shapes via X/Y-Monotone polygons.
- [Impeller] offload all text computation into vertex shader
- [Impeller] delete position_uv, tiled_texture vertex shaders.
- [Impeller] support non-interleaved vertex data.
- [Impeller] fix UV and color blending.
- [Impeller] fix Xcode frame capture.
- [Impeller] Allow batching compute workloads for geometry computations.
- [Impeller] remove framebuffer blending from atlas, fix transform scale
- [Impeller] Fast CPU path for single linear contour path.
- Revert "[Impeller] use host image upload path on simulator"
- [Impeller] Polyline decomp.
- [Impeller] Add UV compute shader.
- [Impeller] Create reusable prefix sum.
- [Impeller] use host image upload path on simulator
- [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS
- [CP] Runtime effect clip fix
- [Impeller] Don't rely on zeroing of threadgroup shared memory, don't early return in quad decomp.
- [Impeller] Wire up compute tessellator.
- [Impelller] fix flickering due to synchronization issues in compute tessellator.
- [Impeller] Fix 1d threadgroup dispatch size, Implement drawPoint geometry computation with compute, fallback to specialized CPU.
- [Impeller] set stencil attachment descriptor for runtime effect.
- [Impeller] Encode render passes concurrently on iOS.
- [Impeller] Dont synthesize fake index buffer if none was provided to VBB
- [Impeller] Increase minimum size of alpha glyph atlas.
- [Impeller] delete special handling of RRect.
- Some pull requests not shown.
flutter/flutter
1
merged
Reviewed 55 pull requests in 3 repositories
flutter/engine
25 pull requests
- [Impeller] Fixed TypographerTest.MaybeHasOverlapping
- Fix unitialized SkRect
- [Impeller] Bias towards sampling from lower mip levels
- [CP] [Impeller] fix UV and color blending. (#42293)
- [Impeller] Switch back to shared buffer UI image uploading on iOS
- [Impeller] Allow batching compute workloads for geometry computations.
- [Impeller] Simplify CreateContentsForGeometry overloads
- [Impeller] Feature detection for subgroup support in Vulkan
- [Impeller] Golden test for text with a shader and a transform
- [Impeller] fix Xcode frame capture.
- [Impeller] Limit rrect blur kernel to 1000x1000
- [Impeller] remove framebuffer blending from atlas, fix transform scale
- Roll watcher dependency for web_ui to 1.1.0.
- [Impeller] Place Entity Geometry classes in separate TUs
- Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573"
- [Impeller] Encode render passes concurrently on iOS.
- [Impeller] Polyline decomp.
- [Impeller] Add UV compute shader.
- [Impeller] Create reusable prefix sum.
- [Impeller] Fix 1d threadgroup dispatch size, Implement drawPoint geometry computation with compute, fallback to specialized CPU.
- [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents
- [Impeller] Don't rely on zeroing of threadgroup shared memory, don't early return in quad decomp.
- [Impeller] Wire up compute tessellator.
- Revert "[ios_platform_view] only recycle maskView when the view is applying mutators"
- [Impeller] Use 32 bit Gaussian function in the 2-pass blur
- Some pull request reviews not shown.
flutter/flutter
7 pull requests
- Marks Mac_ios draw_points_perf_ios__timeline_summary to be unflaky
-
Overall timing information in
TimelineSummary, because existing metrics do not reflect real performance - [web] ui.platformViewRegistry => ui_web.platformViewRegistry
- Remove obsolete iOS benchmark
- [devicelab] add drawPoints benchmark
- [CP] rename AssetManifest.bin to AssetManifest.smcbin
- Report total_ui_gc_time to SkiaPerf
dnfield/vector_graphics
1 pull request
Created an issue in flutter/flutter that received 12 comments
[Impeller] Specific quadradic bezier causes GPU fault in path tessellator.
Path()..quadraticBezierTo(195.0, 200.0, 0.0, 265.0); FYI @dnfield
12
comments
Opened 17 other issues in 1 repository
flutter/flutter
9
open
8
closed
- [Impeller] Invalid pixel format reported in Xcode frame debugger.
- [Impeller] Better handling of multi-contour paths with non-zero fill mode.
- [Impeller] Sufficiently complex paths will freeze tessellator.
- [CP] Ensure RuntimeEffectContents has stencil attachment
- [Impeller] Clip backdrop filter regions before applying expensive filters.
- [Impeller] Investigate framebuffer blend based backdrop blurs.
- [Impeller] Index buffer must be optional.
- [Impeller] eagerly perform geometry computations (and render pass encoding for compute).
- DrawRawPoints has unsafe sharing of point buffer between UI and Raster thread.
- [Impeller] Especially complex paths cause rendering errors, freezes
- [Impeller] Enabling RTree regressed canvas drawing with a large number of operations
- [Impeller] Make glyph atlas construction eager instead of lazy.
- [Impeller] Investigate if we should cache text shadows in the glyph atlas as well.
- [Impeller] Switch iOS/macOS glyph atlas to use a LinearTexture.
- [Impeller] Increase the size of the glyph atlas
- [Impeller] Investigate if glyphs should be cached with a canonicalized color
- [Impeller] Glyphs should be cached with applied skew/rotate transformations