calda
Follow
Pinned
728 contributions in the last year
Contribution activity
April 2023
Created 26 commits in 5 repositories
Created a pull request in apple/swift that received 19 comments
[SE-0365] Fix issue where boolean condition before let self condition would prevent using implicit self
This PR fixes an bug in the implementation of SE-0365 where using a boolean condition before the let self pattern binding condition would prevent t…
+237
−56
•
19
comments
Opened 15 other pull requests in 4 repositories
airbnb/lottie-ios
9
merged
- Bump version to 4.2.0
- Fix issue where trim offset could be calculated incorrectly
-
Fix issue where calling
setValueProviderwould reset animation progress - Update minimum macOS version to 10.11, fix build
- Fix issue where Trim strokeStart / strokeEnd could be rendered in incorrect order
-
Use
XCTExpectFailure(strict: false)for tests that are flaky in CI - Add support for Opacity, Position, Scale, and Rotation value providers
- Fix issue where Trim could be applied to too many shape items
-
Add support for configuring
LottieBackgroundBehaviorto Objective-CCompatibleAnimationView
apple/swift
3
open
1
merged
airbnb/lottie-spm
1
merged
nicklockwood/SwiftFormat
1
merged
Reviewed 11 pull requests in 3 repositories
airbnb/lottie-ios
6 pull requests
-
Fix issue where calling
setValueProviderwould reset animation progress - Fix issue where Trim strokeStart / strokeEnd could be rendered in incorrect order
- Set animationLayer to nil when removing oldAnimation
- Add support for Opacity, Position, Scale, and Rotation value providers
- Fix issue where Trim could be applied to too many shape items
- Fixed 2010: Added trimming whitespaces and newlines condition in dataString.
apple/swift
3 pull requests
airbnb/swift
2 pull requests
Created an issue in nicklockwood/SwiftFormat that received 2 comments
redundantParens rule not removing redundant parens in return statement
We've found some cases where the redundantParens rule isn't removing redundant parenthesis, for example in a return statement. Here are some test c…
2
comments