Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat logrus' WithContext method as a logging function #13835

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't treat logrus' WithContext method as a logging function #13835

wants to merge 2 commits into from
+6 −4

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Jul 28, 2023 •
edited

This isn't output by the default formatters (though a custom formatter could potentially output things stored in it)

Fixes #13828

@smowton
Don't treat logrus' WithContext method as a logging function
6fa2d27 
This isn't output by the default formatters (though a custom formatter could potentially output things stored in it)
@smowton smowton requested a review from a team as a code owner July 28, 2023 13:11
@github-actions github-actions bot added the Go label Jul 28, 2023
@smowton smowton linked an issue Jul 28, 2023 that may be closed by this pull request
False positive: passing context with credentials to logrus #13828
Open
@smowton smowton mentioned this pull request Jul 28, 2023
Open
@smowton smowton requested a review from owen-mc July 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-mc owen-mc owen-mc approved these changes

Assignees
No one assigned
Labels
documentation Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive: passing context with credentials to logrus
2 participants
@smowton @owen-mc