Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 6, 2023

Code Quality: Formatted XAML

Motivation & Context

  • Improved readability

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's one little thing, but it's definetely a non-blocker

yaira2
yaira2 previously approved these changes Jul 17, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x5bfa thank you for the contribution, these changes are useful but for the future, the recommendation is to only apply formatting to files already being worked on. This way, we reduce unnecessary conflicts in other pull requests.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 17, 2023
@yaira2 yaira2 merged commit 19cfc64 into files-community:main Jul 25, 2023
@yaira2
Copy link
Member

yaira2 commented Jul 25, 2023

Thank you

@0x5bfa 0x5bfa deleted the 5bfa/Format-Xaml branch September 16, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants