Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 14, 2023

Code Quality: Introduced the ViewModel for DetailsLayoutBrowser

Motivation & Context

  • Improved readability

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

image

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 14, 2023

Now that we can introduce ContextMenuFlyout generator into there. Instead of looking diff, please take a look at here https://github.com/0x5bfa/Files/blob/5bfa/Add-DetailsColumnsAutoGenerator/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs

@0x5bfa 0x5bfa closed this Jul 16, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Add-DetailsColumnsAutoGenerator branch September 16, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant