Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet the stream locale to "C" locally #724
Conversation
So that even if there is a global locale set by the library user, Jsonnet output is still the same.
|
Fixes #722. It makes sense to add a regression test and check that we don't have the same problem in other places. Perhaps we can have a helper function to create stringstreams and clear the locale? |
|
The test failed on mac gcc. It looked like a legitimate failure with the locale stuff but I didn't understand the error. I ran it again anyway, just in case. |
|
Same thing:
|
|
My guess would be that it needs some packaged installed to get the right locale files. However I'm not sure why it works on clang but not gcc? Maybe they use different standard libraries and the clang library bundles it. |
|
I tried getting to the bottom of this again, but I'm still very confused. One idea that I haven't checked yet is that the locale is just not there, but clang-compiled-version falls back to something "gracefully" and gcc-compiled-version crashes. |
a793333
to
d2aed19
sbarzowski commentedOct 30, 2019
So that even if there is a global locale
set by the library user, Jsonnet output
is still the same.