Commits
main
Name already in use
Commits on Jun 8, 2023
-
fix(react): onDoubleClick fires on components (#27611)
Issue number: Resolves #21320 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `onDoubleClick` bindings on Ionic components do not fire when the element is double clicked. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `onDoubleClick` fires on Ionic components - Fixed the unit testing set-up for the react test apps ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
Commits on Jun 7, 2023
-
fix(refresher): scroll styles are reset when using non-native refresh…
…er (#27602) Issue number: resolves #27601 --------- ## What is the current behavior? The current behavior restores overflow styles while moving (within the setCSS function). ## What is the new behavior? Overflow styles are restored when refresher gesture ends. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> Honestly, I don't know exactly. From code perspective I would say 'Yes', but I can't get the impact of the change. Ionic Team edit: There are no changes to the public API, and this is fixing a behavior that used to work so there are no breaking changes. ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
-
test(segment): undo skip for keyboard navigable (#27574)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The keyboard navigation was being skipped due to flakiness. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> The keyboard navigation is no longer being skipped. - Using the `pageUtils` to Tab - Verify the buttons are visible before keyboard press ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> The flaky test would occur due to the keyboard being pressed before the buttons have loaded in. Weirdly, this only happens when testing "Mobile Chrome" but works fine outside testing.  I would recommend adding `only` to the test and using `npm run test.e2e segment -- --repeat-each 50` to verify that it works.
-
test(back-button): remove unneeded navigation test (#27590)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `navigation` test for `ion-back-button` errors out in the console and doesn't display when attempting to host it locally. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Test removed, since it had no E2E file and the functionality appears to be redundant with the tests for `ion-nav`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
-
-
Commits on Jun 6, 2023
-
fix(header, footer): resolve CSP violations with box shadow (#27560)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `ion-header` and `ion-footer` use a base64 encoded image for a box shadow instead of using the CSS box-shadow property directly. The use of the background image creates CSP violations. The historic reasoning of using an image instead of box shadow was to improve scroll performance. Browsers and devices have improved a lot since that was implemented (5 years ago). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the usage of `ion-header` and `ion-footer` to use a box shadow. The value comes from Material's web implementation: https://material-components.github.io/material-components-web-catalog/#/component/top-app-bar ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
-
chore(deps-dev): Bump @stencil/vue-output-target from 0.8.5 to 0.8.6 …
…in /core (#27607) Bumps [@stencil/vue-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.8.5 to 0.8.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-ds-output-targets/releases"><code>@stencil/vue-output-target</code>'s releases</a>.</em></p> <blockquote> <h2><code>@stencil/vue-output-target</code><a href="https://github.com/0"><code>@0</code></a>.8.6</h2> <h2>What's Changed</h2> <ul> <li>Configure Renovate by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/343">ionic-team/stencil-ds-output-targets#343</a></li> <li>chore(peerDeps): bumping the <code>@stencil/core</code> required peerDep for v4 launch by <a href="https://github.com/JessicaSachs"><code>@JessicaSachs</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/346">ionic-team/stencil-ds-output-targets#346</a></li> <li>chore(npm): manually bumping the package versions by <a href="https://github.com/JessicaSachs"><code>@JessicaSachs</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/349">ionic-team/stencil-ds-output-targets#349</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/renovate"><code>@renovate</code></a> made their first contribution in <a href="https://redirect.github.com/ionic-team/stencil-ds-output-targets/pull/343">ionic-team/stencil-ds-output-targets#343</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-ds-output-targets/compare/@stencil/angular-output-target@0.7.0...@stencil/vue-output-target@0.8.6">https://github.com/ionic-team/stencil-ds-output-targets/compare/<code>@stencil/angular-output-target</code><code>@0.7.0...</code><code>@stencil/vue-output-target</code><code>@0.8.6</code></a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/ionic-team/stencil-ds-output-targets/commits/@stencil/vue-output-target@0.8.6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
chore(deps): Bump @stencil/core from 3.3.0 to 3.3.1 in /core (#27608)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 3.3.0 to 3.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>
🎀 3.3.1 (2023-06-02)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> handle ts 5.0 static members (<a href="https://redirect.github.com/ionic-team/stencil/issues/4447">#4447</a>) (<a href="https://github.com/ionic-team/stencil/commit/6dbe9a5b4548ddb2cd08b389509f22f9895639f9">6dbe9a5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4424">#4424</a></li> <li><strong>e2e:</strong> honor devtools and browserDevtools settings (<a href="https://redirect.github.com/ionic-team/stencil/issues/4403">#4403</a>) (<a href="https://github.com/ionic-team/stencil/commit/fe433b6005ac3e544501ab9d6c481864c84b20f2">fe433b6</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/2537">#2537</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🎀 <a href="https://github.com/ionic-team/stencil/compare/v3.3.0...v3.3.1">3.3.1</a> (2023-06-02)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> handle ts 5.0 static members (<a href="https://redirect.github.com/ionic-team/stencil/issues/4447">#4447</a>) (<a href="https://github.com/ionic-team/stencil/commit/6dbe9a5b4548ddb2cd08b389509f22f9895639f9">6dbe9a5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/4424">#4424</a></li> <li><strong>e2e:</strong> honor devtools and browserDevtools settings (<a href="https://redirect.github.com/ionic-team/stencil/issues/4403">#4403</a>) (<a href="https://github.com/ionic-team/stencil/commit/fe433b6005ac3e544501ab9d6c481864c84b20f2">fe433b6</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/2537">#2537</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/a1aff516a79a9282f7e37a20b492e0dc8a8e3623"><code>a1aff51</code></a>🎀 v3.3.1</li> <li><a href="https://github.com/ionic-team/stencil/commit/6dbe9a5b4548ddb2cd08b389509f22f9895639f9"><code>6dbe9a5</code></a> fix(compiler): handle ts 5.0 static members (<a href="https://redirect.github.com/ionic-team/stencil/issues/4447">#4447</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/c83c1135adcde9d60943a1e7fee92c504f5d74d9"><code>c83c113</code></a> test(options): update version test to account for additional semver cases (<a href="https://redirect.github.com/ionic-team/stencil/issues/4">#4</a>...</li> <li><a href="https://github.com/ionic-team/stencil/commit/2709794ce9cda6151a66c97cafd016a0ebd40552"><code>2709794</code></a> chore(deps): update dependency postcss to v8.4.24 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4445">#4445</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d94869ed0169de36cfe95a9bebbf51637180e8a9"><code>d94869e</code></a> chore(ci): merge queue fixes (<a href="https://redirect.github.com/ionic-team/stencil/issues/4444">#4444</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/3afada59a56729d5bdf7b30f0313f2f271d1b6f0"><code>3afada5</code></a> chore(deps): update dependency webpack to v5.84.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4442">#4442</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/c98150bb961fd77ff4ffabe6ad7dcda34f477e16"><code>c98150b</code></a> chore(ci): update workflows for merge queue (<a href="https://redirect.github.com/ionic-team/stencil/issues/4436">#4436</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/bd1023a67c5224cbae3e445170cb13227a5cf8fb"><code>bd1023a</code></a> chore(deps): update dependency <code>@types/node</code> to v20.2.5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4439">#4439</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/b7c5d2668060d83297f2cf2143464dbad3250498"><code>b7c5d26</code></a> chore(deps): update dependency <code>@types/karma</code> to v6.3.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4438">#4438</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d7d2f3a4112e159745327b52b4c48ce5ea17eee1"><code>d7d2f3a</code></a> chore(deps): update dependency puppeteer to v20.4.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4441">#4441</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v3.3.0...v3.3.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -
Revert "fix(select): prevent click event from firing twice" (#27609)
Reverts #27570 ------- The team is reconsidering this approach as it causes us to fight against the browser. Discussions are ongoing internally, so I am going to revert this patch until we can reach consensus.
-
chore(deps-dev): Bump @stencil/angular-output-target from 0.7.0 to 0.…
…7.1 in /core (#27591) Bumps [@stencil/angular-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.7.0 to 0.7.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/ionic-team/stencil-ds-output-targets/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
fix(item-sliding): refresh sliding behavior when options are added or…
… removed asynchronously (#27572) Issue number: resolves #25578 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> If `ion-item-option`s are added or removed from an `ion-item-sliding` asyncronously/after it has initialized, the sliding behavior of the item will not update. If options are added to an item that didn't have any, the item will not be openable. If all options are removed, the item will still be openable, though no options will render. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> The item now re-checks its options when it detects that any have been added or removed, using the same utility/behavior as `ion-select`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
chore(ci): use correct tag for stencil v4 (#27604)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #27598, I failed to push a change that used the correct tag in the new Stencil v4 tag ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> this commit updates the stencil-version field for the Stencil v4 workflow to use the correct tag ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information [This log](https://github.com/ionic-team/ionic-framework/actions/runs/5190015779) shows it being used properly: <img width="579" alt="Screenshot 2023-06-06 at 10 53 18 AM" src="https://github.com/ionic-team/ionic-framework/assets/1930213/eca96936-a114-4fb5-b473-cbd6bfc71b3a"> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
chore(deps-dev): Bump @stencil/react-output-target from 0.5.0 to 0.5.…
…1 in /core (#27593) Bumps [@stencil/react-output-target](https://github.com/ionic-team/stencil-ds-output-targets) from 0.5.0 to 0.5.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/ionic-team/stencil-ds-output-targets/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
chore(ci): add stencil v4-next workflow (#27598)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> we have no way to test stencil v4 as a part of the nightly build ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> this commit adds a new ci cron job, 'stencil v4 build'. the purpose of this job is to run the ionic framework ci suite on an nightly basis, similar to the stencil nightly build. a separate workflow has been created, as opposed to adding a `matrix` to the pre-existing workflow, as doing so would require a great deal of refactoring to the existing workflow. instead, a separate workflow allows us to simply delete the this workflow once stencil v4 is released. as a part of this commit, we add a new input to the 'build-core-stencil-prerelease' action, allowing users of the action to input the npm tag of `@stencil/core` to install ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information I tested the Stencil nightly job manually - https://github.com/ionic-team/ionic-framework/actions/runs/5180201562 I was unable to run the v4 job, as it's not in `main` (yet
😉 ). But, I can diff it against the known-to-be-good nightly workflow. The following shows only the name of the job & npm tag are different: ```diff diff stencil-v4.yml stencil-nightly.yml 3c3 < name: 'Stencil v4 Build' --- > name: 'Stencil Nightly Build' 21c21 < build-core-with-stencil-v4: --- > build-core-with-stencil-nightly: 27c27 < stencil-version: v4-next --- > stencil-version: nightly 30c30 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 37c37 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 44c44 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 65c65 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 93c93 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 129c129 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] 165c165 < needs: [build-core-with-stencil-v4] --- > needs: [build-core-with-stencil-nightly] ``` <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> -
chore(deps-dev): Bump @playwright/test from 1.34.1 to 1.34.3 in /core (…
…#27576) Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.34.1 to 1.34.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/playwright/releases"><code>@playwright/test</code>'s releases</a>.</em></p> <blockquote> <h2>v1.34.3</h2> <h2>Highlights</h2> <p><a href="https://redirect.github.com/microsoft/playwright/issues/23228">microsoft/playwright#23228</a> - [BUG] Getting "Please install <code>@playwright/test</code> package..." after upgrading from 1.34.0 to 1.34.1</p> <h2>Browser Versions</h2> <ul> <li>Chromium 114.0.5735.26</li> <li>Mozilla Firefox 113.0</li> <li>WebKit 16.4</li> </ul> <p>This version was also tested against the following stable channels:</p> <ul> <li>Google Chrome 113</li> <li>Microsoft Edge 113</li> </ul> <h2>v1.34.2</h2> <h2>Highlights</h2> <p><a href="https://redirect.github.com/microsoft/playwright/issues/23225">microsoft/playwright#23225</a> - [BUG] VSCode Extension broken with Playwright 1.34.1</p> <h2>Browser Versions</h2> <ul> <li>Chromium 114.0.5735.26</li> <li>Mozilla Firefox 113.0</li> <li>WebKit 16.4</li> </ul> <p>This version was also tested against the following stable channels:</p> <ul> <li>Google Chrome 113</li> <li>Microsoft Edge 113</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/playwright/commit/f11873a8950ec622e8294093ee19455d2afb89cc"><code>f11873a</code></a> chore: mark 1.34.3 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23268">#23268</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/b5ff4637791ff9fb191a33e0419e072327148847"><code>b5ff463</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23213">#23213</a>): devops: do not use NPX during docker container build</li> <li><a href="https://github.com/microsoft/playwright/commit/4417a97482a42a5e44bbbe8171037249d5c70faf"><code>4417a97</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23260">#23260</a>): chore: move to npx playwright-core install when using core</li> <li><a href="https://github.com/microsoft/playwright/commit/2f3d88f3d5795d108dc814f90db94eca058eaa35"><code>2f3d88f</code></a> chore: mark 1.34.2 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23242">#23242</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/ba85623f40b001289e2af9fe312fa04b63b7f41e"><code>ba85623</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23241">#23241</a>): chore: keep <code>@playwright/test/</code>cli exposed</li> <li>See full diff in <a href="https://github.com/Microsoft/playwright/compare/v1.34.1...v1.34.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
-
chore(deps-dev): Bump @stencil/sass from 3.0.3 to 3.0.4 in /core (#27592
) Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 3.0.3 to 3.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-sass/releases"><code>@stencil/sass</code>'s releases</a>.</em></p> <blockquote> <h2>v3.0.4</h2> <h2>What's Changed</h2> <h3>Node v20 Support</h3> <ul> <li>chore(node): add node 20 to ci by <a href="https://github.com/rwaskiewicz"><code>@rwaskiewicz</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/313">ionic-team/stencil-sass#313</a></li> </ul> <h3>Stencil v4 Support</h3> <ul> <li>Stencil 4 support by <a href="https://github.com/alicewriteswrongs"><code>@alicewriteswrongs</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/326">ionic-team/stencil-sass#326</a></li> </ul> <h3>Dependency Updates</h3> <p><code>@rollup/plugin-node-resolve</code></p> <ul> <li>chore(deps-dev): bump <code>@rollup/plugin-node-resolve</code> from 15.0.2 to 15.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/325">ionic-team/stencil-sass#325</a></li> </ul> <p><code>@stencil/core</code></p> <ul> <li>chore(deps-dev): bump <code>@stencil/core</code> from 3.2.2 to 3.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/320">ionic-team/stencil-sass#320</a></li> </ul> <p><code>@types/node</code></p> <ul> <li>chore(deps-dev): bump <code>@types/node</code> from 16.18.25 to 20.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/323">ionic-team/stencil-sass#323</a></li> </ul> <p><code>terser</code></p> <ul> <li>chore(deps-dev): bump terser from 5.17.5 to 5.17.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/319">ionic-team/stencil-sass#319</a></li> <li>chore(deps-dev): bump terser from 5.17.6 to 5.17.7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/327">ionic-team/stencil-sass#327</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/alicewriteswrongs"><code>@alicewriteswrongs</code></a> made their first contribution in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/326">ionic-team/stencil-sass#326</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.3...v3.0.4">https://github.com/ionic-team/stencil-sass/compare/v3.0.3...v3.0.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-sass/commit/2065dd67701973159f3cba6a94e852e5d1b00079"><code>2065dd6</code></a> 3.0.4</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/acd41b4bae71bcd67b75d7bd0298aef216273f36"><code>acd41b4</code></a> chore(deps-dev): bump <code>@types/node</code> from 16.18.25 to 20.2.5 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/323">#323</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/4ed25637e955d7554a2a45abd34fc74d3c0e4e5c"><code>4ed2563</code></a> chore(node): add node 20 to ci (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/313">#313</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/c8618ba22f872834a02c92853485e9f46f1ef804"><code>c8618ba</code></a> chore(ci): add Stencil v4 and latest versions to CI matrix</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/839787af44f3ced65c34579a2745736a09d0dc19"><code>839787a</code></a> chore(peer-deps): update <code>@stencil/core</code> peer dep to allow v4 + beta</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/2e0680ef266d64f6e4204da8468d284322998a82"><code>2e0680e</code></a> chore(deps-dev): bump <code>@rollup/plugin-node-resolve</code> from 15.0.2 to 15.1.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/325">#325</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/4a6b609efe9a4bb3572b7939ebd82eb94560de85"><code>4a6b609</code></a> chore(deps-dev): bump terser from 5.17.6 to 5.17.7 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/327">#327</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/941c3a9f468a4efb3ab4a3e1ad83d7494de7334f"><code>941c3a9</code></a> chore(deps-dev): bump <code>@stencil/core</code> from 3.2.2 to 3.3.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/320">#320</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/d22216aa2e0ba055aa104df8475b4328ce8d3911"><code>d22216a</code></a> chore(deps-dev): bump terser from 5.17.5 to 5.17.6 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/319">#319</a>)</li> <li>See full diff in <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.3...v3.0.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commits on Jun 5, 2023
-
fix(select): prevent click event from firing twice (#27570)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The click event was firing twice. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The click event fires once. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> You can use the test file to see that the event now fires once, and before this change it fired twice. I couldn't figure out how to write an automated test for this that fails before the change and passes after the change. (Perhaps because of how Jest "clicks" elements? Not sure.) Also, you can use the repro repo in the Jira ticket and update it to `"@ionic/angular": "7.0.10-dev.11685472954.170be0cc",` and see that the issue is fixed.
Commits on Jun 2, 2023
-
chore(deps-dev): Bump @axe-core/playwright from 4.7.1 to 4.7.2 in /co…
…re (#27585) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.7.1 to 4.7.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/releases"><code>@axe-core/playwright</code>'s releases</a>.</em></p> <blockquote> <h2>Release 4.7.2</h2> <h3>Bug Fixes</h3> <ul> <li><strong>packages/cli:</strong> revert ESM (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/730">#730</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/4e1fb958fa251db7eea3433f91f2a2f3adbda1e8">4e1fb95</a>)</li> <li><strong>playwright:</strong> Enable usage with <code>@playwright/test</code> (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/731">#731</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/0d0c9d1b75051b26f0bb745abc5c8974a9fa4d54">0d0c9d1</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h1>Change Log</h1> <p>All notable changes to this project will be documented in this file. See <a href="https://conventionalcommits.org">Conventional Commits</a> for commit guidelines.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/3d06f08937bc2d8d5bb985668a32101ad05d44f5"><code>3d06f08</code></a> chore: better test structure / name conistency (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/738">#738</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/fe3721d914c00c956738b40a528c04b97e707d39"><code>fe3721d</code></a> ci: remove tests from the <code>develop</code> and <code>master</code> branch (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/735">#735</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/83092abdf6d94e17cb8cb47fdf3260ae74c9da4d"><code>83092ab</code></a> chore: update chromedriver (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/734">#734</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/0d0c9d1b75051b26f0bb745abc5c8974a9fa4d54"><code>0d0c9d1</code></a> fix(playwright): Enable usage with <code>@playwright/test</code> (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/731">#731</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/4e1fb958fa251db7eea3433f91f2a2f3adbda1e8"><code>4e1fb95</code></a> fix(packages/cli): revert ESM (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/730">#730</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/23701dcbd2e57ef74b737798828475bf1dab7da3"><code>23701dc</code></a> chore: merge master into develop (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/724">#724</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/32caffdbe7688e43b73b242113e684ff31edfc7d"><code>32caffd</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/723">#723</a> from dequelabs/release-1683060243</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/49161f5c8c224b2e93f89c7b7e454e294cfb8447"><code>49161f5</code></a> chore: release v4.7.1</li> <li>See full diff in <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.7.1...v4.7.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commits on May 31, 2023
-
fix(radio): radio with modern syntax is keyboard navigable (#27530)
Issue number: resolves #27268 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When tabbing on a radio group (modern syntax), it focuses on the next radio option inside the radio group. It replicates the behavior of the up/down keys. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - When tabbing on a radio group (modern syntax), it focuses on the next radio option of the next radio group. A spike ticket has been created to further investigate web accessibility and browser compatibility. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
-
fix(keyboard): listen on correct events for keyboard lifecycle (#27569)
Issue number: resolves #27558 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The keyboard lifecycle util was always listening on visual viewport events even when in native environments. The visual viewport API is not reliable due to how the Ionic webview customizes how it resizes. We should only be listening on the native keyboard events in native environments. ionic-team/capacitor#3730 https://github.com/ionic-team/capacitor-plugins/blob/2e883f39329626062bcf876fe7d424432617229d/keyboard/ios/Plugin/Keyboard.m#L90-L98 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Keyboard lifecycle util listens on native keyboard events only when in native environment ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
chore(deps): Bump @stencil/core from 3.2.2 to 3.3.0 in /core (#27539)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 3.2.2 to 3.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>
🍭 3.3.0 (2023-05-23)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> components typedef path aliases (<a href="https://redirect.github.com/ionic-team/stencil/issues/4365">#4365</a>) (<a href="https://github.com/ionic-team/stencil/commit/fd63c1779a2b4889be536e23ad763199f02d861d">fd63c17</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>node</strong> add support for node v20 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4368">#4368</a>) (<a href="https://github.com/ionic-team/stencil/commit/ffe1847062ccae0e2b525ac290e3ac977e3ad6a3">ffe1847</a>)</li> <li><strong>testing:</strong> support puppeteer's 'headless': 'new' (<a href="https://redirect.github.com/ionic-team/stencil/issues/4356">#4356</a>) (<a href="https://github.com/ionic-team/stencil/commit/79dc0159d216824d623e34f814dfeb32474a1550">79dc015</a>)</li> <li><strong>typescript:</strong> upgrade to TypeScript 5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4315">#4315</a>) (<a href="https://github.com/ionic-team/stencil/commit/0b6621f21634b7498de0666a872ffcacc93fef87">0b6621f</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🍭 <a href="https://github.com/ionic-team/stencil/compare/v3.2.2...v3.3.0">3.3.0</a> (2023-05-23)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> components typedef path aliases (<a href="https://redirect.github.com/ionic-team/stencil/issues/4365">#4365</a>) (<a href="https://github.com/ionic-team/stencil/commit/fd63c1779a2b4889be536e23ad763199f02d861d">fd63c17</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>node</strong> add support for node v20 (<a href="https://redirect.github.com/ionic-team/stencil/pull/4368">#4368</a>) (<a href="https://github.com/ionic-team/stencil/commit/ffe1847062ccae0e2b525ac290e3ac977e3ad6a3">ffe1847</a>)</li> <li><strong>testing:</strong> support puppeteer's 'headless': 'new' (<a href="https://redirect.github.com/ionic-team/stencil/issues/4356">#4356</a>) (<a href="https://github.com/ionic-team/stencil/commit/79dc0159d216824d623e34f814dfeb32474a1550">79dc015</a>)</li> <li><strong>typescript:</strong> upgrade to TypeScript 5 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4315">#4315</a>) (<a href="https://github.com/ionic-team/stencil/commit/0b6621f21634b7498de0666a872ffcacc93fef87">0b6621f</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/7515c4b83659faee0c856f7877bde8fb564391f5"><code>7515c4b</code></a>🍭 v3.3.0</li> <li><a href="https://github.com/ionic-team/stencil/commit/b34a88dd7426b18c75ee68fdccf2a114be373c6d"><code>b34a88d</code></a> chore(karma): update package-lock format (<a href="https://redirect.github.com/ionic-team/stencil/issues/4417">#4417</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/15e4743e7ee4abe7c9feb19dffb9fab8d3b0c378"><code>15e4743</code></a> chore(readme): add discord to readme (<a href="https://redirect.github.com/ionic-team/stencil/issues/4408">#4408</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a0207588bf4a8f3fb426e656d3d59f34325b162"><code>9a02075</code></a> chore(deps): update dependency webpack to v5.83.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4413">#4413</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/db39b030379c384ba8a9b0c79e669de6c3e93fca"><code>db39b03</code></a> chore(deps): update dependency npm to v9.6.7 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4410">#4410</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a422f93452d25d3d4f7fc60eb64f75dafa26ee64"><code>a422f93</code></a> chore(deps): update dependency eslint to v8.41.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4416">#4416</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a690e48c97234e0c7b420f2120db015addc1ca64"><code>a690e48</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v44.2.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4409">#4409</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a0bd934b4cc5d6ac607372ae3d23002daa6c1367"><code>a0bd934</code></a> chore(deps): update typescript-eslint to v5.59.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4411">#4411</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/bb329c937774924087e94d353a7bc7d2b6701e86"><code>bb329c9</code></a> chore(deps): update dependency <code>@types/node</code> to v20.2.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4412">#4412</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0673f72197596facc2904e598f3029b96b4f4dba"><code>0673f72</code></a> chore(snc): remove in-memory-fs.spec snc violations (<a href="https://redirect.github.com/ionic-team/stencil/issues/4401">#4401</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v3.2.2...v3.3.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Commits on May 30, 2023
-
test(datetime): reduce flakiness (#27549)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Sometimes the datetime picker hasn't scrolled to the correct date yet before the screenshot is taken. (See JIRA ticket for a failing build.) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The test waits until the picker has scrolled before taking the screenshot. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Hopefully this is all that's needed. I did a few runs and it hasn't failed, but it's hard to know with flaky tests
🙃 -
test(list): screenshot capture only the list container (#27571)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The basic list test screenshots capture a portion of the box shadow from the `ion-header`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes the `ion-header` from the test template for screenshot capture - Only visually captures the `ion-list` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
-
chore: remove team assignment from codeowners (#27573)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> PRs are first assigned to the team before being assigned to a single team member. This causes reviews to show up https://github.com/notifications for everyone even if they are not the final reviewer. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - GitHub automatically assigns reviewers now, so I removed the global Framework team codeowner. All PRs in this repo should have a team member automatically assigned. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
chore(deps-dev): Bump @playwright/test from 1.33.0 to 1.34.1 in /core (…
…#27533) Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.33.0 to 1.34.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/playwright/releases"><code>@playwright/test</code>'s releases</a>.</em></p> <blockquote> <h2>v1.34.0</h2> <h3>Highlights</h3> <ul> <li> <p>UI Mode now shows steps, fixtures and attachments: <!-- raw HTML omitted --></p> </li> <li> <p>New property <a href="https://playwright.dev/docs/api/class-testproject#test-project-teardown"><code>testProject.teardown</code></a> to specify a project that needs to run after this and all dependent projects have finished. Teardown is useful to cleanup any resources acquired by this project.</p> <p>A common pattern would be a <code>setup</code> dependency with a corresponding <code>teardown</code>:</p> <pre lang="js"><code>// playwright.config.ts import { defineConfig } from '@playwright/test'; <p>export default defineConfig({ projects: [ { name: 'setup', testMatch: /global.setup.ts/, teardown: 'teardown', }, { name: 'teardown', testMatch: /global.teardown.ts/, }, { name: 'chromium', use: devices['Desktop Chrome'], dependencies: ['setup'], }, { name: 'firefox', use: devices['Desktop Firefox'], dependencies: ['setup'], }, { name: 'webkit', use: devices['Desktop Safari'], dependencies: ['setup'], }, ], }); </code></pre></p> </li> <li> <p>New method <a href="https://playwright.dev/docs/test-assertions#expectconfigure"><code>expect.configure</code></a> to create pre-configured expect instance with its own defaults such as <code>timeout</code> and <code>soft</code>.</p> <pre lang="js"><code>const slowExpect = expect.configure({ timeout: 10000 }); await slowExpect(locator).toHaveText('Submit'); <p>// Always do soft assertions. const softExpect = expect.configure({ soft: true }); </code></pre></p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/playwright/commit/4aee014caf4d5f14700a18dfc25014812e1f4414"><code>4aee014</code></a> chore: mark 1.34.0 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23123">#23123</a>)</li> <li><a href="https://github.com/microsoft/playwright/commit/bf25a936175765c89bf9e0e241c0816995e6e025"><code>bf25a93</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23171">#23171</a>): fix(tracing): when zipping remotely, use correct file na...</li> <li><a href="https://github.com/microsoft/playwright/commit/7effaf4f22fc658833e608415634185a43f7e535"><code>7effaf4</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23166">#23166</a>): chore: fix file view padding</li> <li><a href="https://github.com/microsoft/playwright/commit/ef18287266b0a9131c70dd552964884c6af682ec"><code>ef18287</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23165">#23165</a>): docs: update release notes</li> <li><a href="https://github.com/microsoft/playwright/commit/552cba8c05b1750dea5fea84072dfdf7405545f1"><code>552cba8</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23148">#23148</a>): chore: do not annotate actions after failed ones as time...</li> <li><a href="https://github.com/microsoft/playwright/commit/cd94a3f01dd9693a167a5f66a4096e7ca58bd879"><code>cd94a3f</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23144">#23144</a>): feat(connect): <code>pw:server:channel</code> and <code>pw:socks</code> debug ...</li> <li><a href="https://github.com/microsoft/playwright/commit/3543a741fdf67cf14f2457c5058ef03691c3036e"><code>3543a74</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23140">#23140</a>): docs: add dialog/consoleMessage helper methods for langu...</li> <li><a href="https://github.com/microsoft/playwright/commit/7196f82e52571d177f0956cb2913add007a52dbf"><code>7196f82</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23143">#23143</a>): test: add attachment tests</li> <li><a href="https://github.com/microsoft/playwright/commit/32c247b81556e6af9b2023438dc4628caa249c8f"><code>32c247b</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23139">#23139</a>): chore: opt out of trace attachments</li> <li><a href="https://github.com/microsoft/playwright/commit/c551cce74e47a124cf8ad7f79cda3ade7ac88a45"><code>c551cce</code></a> cherry-pick(<a href="https://redirect.github.com/Microsoft/playwright/issues/23130">#23130</a>): feat(chromium): roll to r1064 (<a href="https://redirect.github.com/Microsoft/playwright/issues/23132">#23132</a>)</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/playwright/compare/v1.33.0...v1.34.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com>
-
perf: passive event listener for focus visible (#27568)
Issue number: resolves #27566 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `touchstart` listener for focus visible is not marked as passive. This causes a browser delay in case `touchstart` calls `ev.preventDefault()`. However, we are not doing that in this block of code. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Added `passive: true` to the `touchstart` listener to avoid the browser delay. Note that this is only needed for touch and wheel events which is why I only modified `touchstart`: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
fix(angular): remove invalid z-index style (#27559)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The Angular implementation of `ion-tabs` uses SASS styles in the inline usage for styles: ```ts styles: [` :host { z-index: $z-index-page-container; } `] ``` However Angular is expecting CSS mark-up by default. This results in an invalid value being assigned to the `z-index`.  ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes the invalid style from the tabs stylesheet - Removes unnecessary leading whitespace from the template ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->