New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (main): vendor in Python packaging for Py3.12 #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need line 15 in the TOML file?
The line that says dependencies = ["packaging>=23.1"]
|
I think for open source license compliance, |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubberstamp
|
This PR worked for me! The details of my testing are posted below, for anyone who is curious. Test method:
Confirming this fix was needed (Testing the "null hypothesis"):
Main Result (This PR Fixes the Errors):
|
|
I confirm that macOS homebrew's |
Fixes #211
Fixes #213
Related to:
distutilslibrary node-gyp#28883.11.6Missingdistutilsmodule node-gyp#2915distutilswas removed in Python 3.12 and the Python Packaging Authority recommends usingpackaginginstead.Let's vendor in
packagingso that installingnode-gypdoes not require runningpip install packaging.@rzhao271 @DeeDeeG @StefanStojanovic @brjsp