Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'configure' to import yaml settings nested deeper than 2 levels #470

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

danwelch3
Copy link
Contributor

Resolves #466

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

@thebentern
Copy link
Contributor

Please sign the CLA

@AeroXuk AeroXuk mentioned this pull request Apr 9, 2024
@AeroXuk
Copy link
Contributor

AeroXuk commented Apr 9, 2024

@danwelch3
Please sign the CLA so that this change can be merged.
I've added a few extra edits under pull request #543 however these also can't be merged until you've signed the CLA.
You can sign it by clicked the below and agreeing the T&C.

https://cla-assistant.io/meshtastic/python?pullRequest=470

@danwelch3
Copy link
Contributor Author

I've signed the CLA. In the past I had issues with it showing, so let me know if it worked this time.

@AeroXuk
Copy link
Contributor

AeroXuk commented Apr 9, 2024

@danwelch3 You may need to double check that the email address you used on the git commit is linked the the same account you signed the CLA with. I can see the email on the commit is linked to this account @dwsc, but the PR is raised with @danwelch3.

You could also try adding the other email via https://github.com/settings/emails

@danwelch3
Copy link
Contributor Author

Thanks for pointing that out. I signed the CLA with the other account now.

- add docstring to traverseConfig function
@ianmcorvidae ianmcorvidae merged commit d810712 into meshtastic:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import settings.yaml having static IP set
6 participants