crypto: add validFromDate and validToDate fields to X509Certificate

[RulerOfCakes]

Resolves #52931.

Since OpenSSL already provides validity checking based on the current time, it may be handy to provide such checks as a part of the X509Certificate API exposed by node. I have made some simple changes to provide such functionality using the default behavior of X509_cmp_timeframe() provided by OpenSSL.

Edit: Instead of providing the user with the date string format provided by OpenSSL's formatting for ASN.1 time objects, I have added parsing logic accordingly to provide them in the form of Javascript Date objects instead to make user interaction easier with these fields.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[codecov]

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (75d25bc) to head (a88395d).
Report is 43 commits behind head on main.

Files	Patch %	Lines
src/crypto/crypto_x509.cc	84.61%	0 Missing and 4 partials ⚠️
lib/internal/crypto/x509.js	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54159      +/-   ##
==========================================
+ Coverage   87.09%   87.32%   +0.23%     
==========================================
  Files         648      648              
  Lines      182250   182367     +117     
  Branches    34967    34977      +10     
==========================================
+ Hits       158732   159255     +523     
+ Misses      16797    16376     -421     
- Partials     6721     6736      +15     

Files	Coverage Δ
lib/internal/crypto/x509.js	92.01% <90.00%> (+9.67%)	⬆️
src/crypto/crypto_x509.cc	72.65% <84.61%> (+0.45%)	⬆️

... and 57 files with indirect coverage changes

[mertcanaltin]

lgtm

[RulerOfCakes]

sorry for the messy CI. I didn't realize timegm was unavailable cross-platform, so I'm trying to figure out an alternative but can't really test all these environments in my local environment. The previous C++ standard library based one seemed to produce some weird errors(which I think might be related to daylight savings), so I've changed it to a C-based one.

@daeyeon Could you please help me check if it works now in the CI?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61190/