test: improve flakiness detection on stack corruption tests #58601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change skips asserting the exit code of the child process with the corrupted async hooks stack only on those platforms where termination via a signal has been observed. Refs: nodejs#58478 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
added
async_hooks
This was referenced Jun 6, 2025
juanarbol
approved these changes
Jun 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58601 +/- ##
==========================================
- Coverage 90.19% 90.19% -0.01%
==========================================
Files 635 636 +1
Lines 187495 187698 +203
Branches 36819 36845 +26
==========================================
+ Hits 169116 169298 +182
- Misses 11158 11164 +6
- Partials 7221 7236 +15 🚀 New features to boost your workflow:
|
|
I think the questions remain. What is causing |
In #58463 (comment), @Flarna suggested that this might be caused by a resource limitation. Someone from @nodejs/platform-aix might be able to confirm.
Since this tests an async hooks stack corruption I don't know how relevant it is. Can someone from @nodejs/async_hooks answer that? |
joyeecheung
approved these changes
Jun 6, 2025
RafaelGSS
approved these changes
Jun 6, 2025
lpinca
approved these changes
Jun 6, 2025
RaisinTen
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in b23648e |
RaisinTen
deleted the
test/improve-flakiness-detection-on-async-hooks-stack-corruption-tests
branch
aduh95
pushed a commit
that referenced
this pull request
Jun 8, 2025
This change skips asserting the exit code of the child process with the corrupted async hooks stack only on those platforms where termination via a signal has been observed. Refs: #58478 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58601 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips asserting the exit code of the child process with the corrupted async hooks stack only on those platforms where termination via a signal has been observed.
Refs: #58478 (comment)