Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Remove magic number #3
Open
Conversation
|
@jspc fair enough. I like to avoid using CAPS as constant names, and maybe it should exit with |
|
Happy to change it, I wrote it with a cap and underscore because that's the
convention we see in unix usually.
Though, of course, that's usually c or bash.
Commit incoming.
…On Wed, 9 May 2018, 19:51 Mat Ryer, ***@***.***> wrote:
@jspc <https://github.com/jspc> fair enough. I like to avoid using CAPS
as constant names, and maybe it should exit with 1 instead? There is
nothing special, just need a non-zero exit code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAxclb2HLMxsb3znxYpGlrNaxVtWkjtmks5twzqngaJpZM4T2mwM>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently this tool throws
exit(2)on error. This doesn't mean anything and is a magic number.Instead this PR defines it as an error.
The choice of
2is out of the scope of this PR.