Pinned
2,326 contributions in the last year
Less
More
Contribution activity
February 2021
Created 4 repositories
Created a pull request in sourcegraph/sourcegraph that received 4 comments
dev: fix typo in alpine guard check
Spotted this when I saw a Misc Linters job failing (doesn't affect green build?)
+2
−2
•
4
comments
Opened 29 other pull requests in 3 repositories
sourcegraph/sourcegraph
2
open
22
merged
1
closed
- search frontend: reorder context field alphabetically
- search frontend: suggestion order derives from list order, not alphabetically
- search: fix build for missing import
- search: remove query/alert.go
- search: delete query/syntax
- search frontend: add select field and discrete values
- search: alphabetize filter definitions
- search: move filter types to filter.ts, remove util.ts
- search: delete dead validation function
- search: remove unused ParseTree method
- search: refactor query.Query stutter
- search: factor out query values and delete query/types
- search: remove query/types
- search: one query type
- search: remove OrdinaryQuery
- search: move fields out of searchquery.go
- search: remove use of query.Process
- search: remove ParseTree from query interface
- search: remove alert dependency on ParseTree [2/2]
- search: remove alert dependency on ParseTree [1/2]
- search: add function to convert query tree to string
- search: fix parser lints
- search: choose matcher from filename result
- search: better error for unsupported not queries
- search: hint for structural search on ... syntax
comby-tools/comby
3
merged
slimsag/Packages
1
merged
Reviewed 40 pull requests in 2 repositories
sourcegraph/sourcegraph 39 pull requests
- search: create a search result dedupper and update unionMerge
- search: Add unionMerge test
- dev: fix typo in alpine guard check
- search: remove zoekt.MatchLimiter
- search: filters aggregate counts over results
- Revert "search: create a search result dedupper and update unionMerge"
- search: create a search result dedupper and update unionMerge
- search: delete query/syntax
- search: do not include + suffix in progress count
- Search contexts: context filter suggestions
- search frontend: add select field and discrete values
- search: apply limit across backends in streaming
- search: do not report more than count MatchCount
- search: remove FileMatch.MatchCount
- search: Add selector interface
- search: Convert struct field accesses to method calls
- Remove orphan comment
- search: refactor query.Query stutter
- search: factor out query values and delete query/types
- Search contexts: Support context keyword in the search frontend
- search: Fix getting results for non-existant files
- search: don't run global search path if index:no
- search: remove OrdinaryQuery
- search: remove use of query.Process
- search: remove alert dependency on ParseTree [2/2]
- Some pull request reviews not shown.
slimsag/Packages 1 pull request
Created an issue in sourcegraph/sourcegraph that received 4 comments
Impelement select: (RFC 254)
Implementation plain for select: in the search query:
Backend
@camdencheek will start off on the backend work items. Feel free to create GH issues …
•
4
comments
Opened 17 other issues in 2 repositories
diem/diem
10
open
- [Bug][move compiler] Panick: Out of bounds access at translate.rs:1532
- [Bug][move compiler] Panick: 'ICE type constraints failed' at translate.rs:409
- [Bug][move compiler] Panick: `Result::unwrap()` on an `Err` value: Invalid identifier '_'' at source_map.rs
- [Bug][Move compiler] Panic: 'ICE invalid use of tmp local' at state.rs:315
- [Bug][move compiler] Panick: 'ICE invalid bind_exp for single value' in hlir/translate.rs:1167
- [Bug][move compiler] Panick: 'assertion failed: all_refs.is_empty()' at state.rs:671:9
- [Bug][move compiler] Panick: 'called `Option::unwrap()` on a `None` value' at liveness/mod.rs:176
- [Bug][move compiler] stack overflow
- [Bug][move compiler] Panick: context.has_errors() called at translate.rs:652:9
- [Bug][move compiler] Panick: 'ICE in_loop should be reset after the loop' called at core.rs:114:9
sourcegraph/sourcegraph
4
open
3
closed
- Streaming duplicates `or` expression results
- add diagnostic to detect glob-like / meaningless regex patterns in repo, file
- 'and' on text search for commits don't work (returns no results)
- Some timeout suggestions not preserving original query
- Don't search files that don't exist on certain branches/commits on structural search path
- We don't higlight Julia files
- -d flag ignored when patterns are interpreted as file paths
1
contribution
in private repositories
Feb 1