jmagman
Follow
jmagman
Follow
Pinned
1,606 contributions in the last year
Less
More
Contribution activity
April 2022
Created 28 commits in 7 repositories
Created 1 repository
Created a pull request in flutter/samples that received 13 comments
Do not run GitHub workflows on forks
I keep getting emails that GitHub workflow runs are failing on by fork. Set if in workflow config to not run in forks, only PRs off flutter/samples:
…
+13
−5
•
13
comments
Opened 31 other pull requests in 7 repositories
flutter/flutter
2
open
15
merged
3
closed
- Upgrade CI Xcode version to 13.1
- Embed Flutter and App frameworks for add-to-app on iOS
- Handle CocoaPods ffi stderr
- Fail integration test if expected bitcode markers not found
- Update codesign script to handle Flutter.xcframework/ios-arm64 without armv7
- Exclude armv7 arch from iOS add-to-app integration test hosts
- Set template and migrate apps to iOS 11 minimum
- Exclude armv7 from iOS add-to-app plugins
- Detect ARM ffi CocoaPods bus error
-
Add
flutter build ipa --no-codesignflag - Update module_test_ios google_sign_in version
- Test Flutter.xcframework directory ios-arm64_armv7 or ios-arm64
- Run update-packages
- Add --use-application-binary to "flutter install"
- Run CADisableMinimumFrameDurationOnPhone migration on all example apps
- Add note to doctor validator if script is running Rosetta
- Only run test harness tests in misc shard instead of every shard
- Remove dead dartdocs.dart file
- Remove gems dependency from tests that do not use it
- Remove --enable-web and --enable-windows-desktop from tests
flutter/website
1
closed
4
merged
flutter/engine
1
closed
1
merged
fuzzybinary/flutter_os_activity_example
1
open
flutter/plugins
1
merged
flutter/samples
1
merged
flutter/cocoon
1
merged
Reviewed 61 pull requests in 8 repositories
flutter/flutter
25 pull requests
- [flutter_releases] Flutter beta 2.13.0-0.3.pre Framework Cherrypicks
-
Update open sdk version to be version
version:11 - [macOS] Adds macOS project files to layers example
-
Enable Mac/android arm64 tests as
bringup: true - Embed Flutter and App frameworks for add-to-app on iOS
- Enable M1 mac/ios tests in prod as bringup: false
-
Put
waitForback in keyboard_textfield_test integration test -
Enable DeviceLab arm64 ios tests as
bringup: true - Marks Mac_ios native_ui_tests_ios to be unflaky
- Roll Engine from dd6ef5dd5b68 to 5ab671f54e17 (1 revision)
- [flutter_tools] explicitly enable macos-desktop in macos_content_validation_test.dart
- Skip logging stderr/stdout if xcresult parsing is successful
- Exclude armv7 arch from iOS add-to-app integration test hosts
- Hide default bundle id error when xcresult detects an error
- Set template and migrate apps to iOS 11 minimum
- Enforce cpu explicitly for Mac devicelab test beds
- Exclude armv7 from iOS add-to-app plugins
- [flutter_tools] shard out two integration tests we want to run on macOS arm64
-
Migrate tool results on
examples/hello_world -
Add
flutter build ipa --no-codesignflag - [flutter_tools] Re-land Dump backtrace on ios app startup timeout
- [flutter_tools] Dump backtrace on ios app startup timeout
- Enable track widget creation when generating Generated.xcconfig
- Test Flutter.xcframework directory ios-arm64_armv7 or ios-arm64
- [flutter_tools] add test for dart binary arch
- Some pull request reviews not shown.
flutter/engine
11 pull requests
- iOS spell-checker ObjC
-
[iOS] Add
UITextInteractiononly wheninputDelegateis nil - [web] remove dependency on web_installers
- Reland "Update Web Engine to use Mac-12."
- Reland: Ignore armv7 in ios framework script
- Revert "Update Web Engine to use Mac-12."
- Update Web Engine to use Mac-12.
- Set IosUnitTests minimum to iOS 15, disallow iPads to work around CI simulator issues
- Only install iOS simulator runtimes on builders that use them
- Fix a crash when setting clipboardData to null on iOS
- Set iOS default frame rate to screen max.
flutter/cocoon
7 pull requests
- [dashboard] Fix ios and android filters
- Remove repo_dashboard
- Update modify mode when creating PRs via auto flake bot
- issue #102000, making cocoon dashboard task name filter case insensitive
- make devicelab tests count as tests
- Add cpu dimension support when parsing ci yaml
- Do not run scorecards on forks.
flutter/plugins
4 pull requests
flutter/website
3 pull requests
flutter/impeller
2 pull requests
flutter/codelabs
1 pull request
jmagman/dan-replacer
1 pull request
Created an issue in flutter/flutter that received 10 comments
Google testing fails on icon_map_generator Icon "Too few positional arguments: 2 required, 1 given."
Seen in cl/440438444 during unrelated #100787
google3:///[mobile/flutter/tools/icon_font/bin/icon_map_generator.dart:46](https://cs.corp.google.com…
10
comments
Opened 12 other issues in 2 repositories
flutter/flutter
5
open
5
closed
- [CP] Handle CocoaPods ffi stderr
- Allow hot reload to be triggered from Xcode console without "flutter attach"
- Cocoon task name filtering should be case insensitive
- Update all plugins minimum from iOS 9 to iOS 11
-
Set buildroot
ios_deployment_targetto 11.0 - Increase plugin minimum supported iOS version from 9.0 to 11.0, match Flutter SDK constraint
- Increase app minimum supported iOS version from 9.0 to 11.0
-
☂️ Increase minimum support iOS version from 9 to 11 -
Exclude
arm7vfrom iOS architectures when building add-to-app plugins in host app with CocoaPods -
Add
flutter build ipa --no-codesignflag