Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files & folders dropped on Welcome Window are opened #1169

Merged
merged 1 commit into from Mar 19, 2023
Merged

Files & folders dropped on Welcome Window are opened #1169

merged 1 commit into from Mar 19, 2023

Conversation

Wouter01
Copy link
Member

@Wouter01 Wouter01 commented Mar 18, 2023 •
edited

Description

Files & Folders dropped on the Welcome Window are opened. Multiple items dropped at the same time is supported.

shouldCascade is also set to true, as disabling this overlaps workspace windows if multiple are opened

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@Wouter01
Files & folders dropped on welcomewindow are opened
b96463b 
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
@Wouter01 Wouter01 added the enhancement New feature or request label Mar 18, 2023
@Wouter01 Wouter01 self-assigned this Mar 18, 2023
@Wouter01 Wouter01 linked an issue Mar 18, 2023 that may be closed by this pull request
✨ Dragging file on top of the "Welcome" window should open it #1164
Closed
0xWDG
0xWDG approved these changes Mar 18, 2023
View changes
@Wouter01 Wouter01 enabled auto-merge (squash) March 18, 2023 19:12
@Wouter01 Wouter01 merged commit e25a90c into CodeEditApp:main Mar 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@matthijseikelenboom matthijseikelenboom

@lukepistrol lukepistrol

@thecoolwinter thecoolwinter

@KaiTheRedNinja KaiTheRedNinja

Assignees

@Wouter01 Wouter01

Labels
enhancement New feature or request
Projects
CodeEdit Project
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Dragging file on top of the "Welcome" window should open it
3 participants
@Wouter01 @austincondiff @0xWDG