doc: add esm examples to node:dns
#54172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dns
aduh95
reviewed
Aug 2, 2024
aduh95
reviewed
Aug 2, 2024
aduh95
reviewed
Aug 2, 2024
aduh95
reviewed
Aug 2, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
lpinca
approved these changes
Aug 3, 2024
trivikr
approved these changes
Aug 4, 2024
aymen94
approved these changes
Aug 6, 2024
UlisesGascon
approved these changes
Aug 6, 2024
aduh95
approved these changes
Aug 6, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in e2c6220 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54172 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ESMcounterparts of theCJSexamples for the DNS documentation.I've also updated examples like this one to reflect the up-to-date output for the
lookup(it's anIPv6address now).I've also changed the examples that used
example.comforexample.orgjust to be consistent with the rest of the examples and to update the actual response received nowadays.I've tested every single example and they all work/behave as expected.
Best regards!